authentication errors do not call defined failure root

[andrew-whitmore]

lib/omniauth/strategies/azure_activedirectory.rb:88 always raises errors regardless of the environment that the application is in.

The omniauth implementation suggests that any environment apart from development will push errors to the defined /auth/failure path

[ckritzinger]

You can monkey-patch this into submission with:

  # monkey-patch
  module OmniAuth
    module Strategies
      class AzureActiveDirectory
        def callback_phase
          error = request.params['error_reason'] || request.params['error']
          if error
              return self.fail!(error)
          end
          @session_state = request.params['session_state']
          @id_token = request.params['id_token']
          @code = request.params['code']
          @claims, @header = validate_and_parse_id_token(@id_token)
          validate_chash(@code, @claims, @header)
          super
        end

That will cause it to behave like the OmniAuth docs claims it should.