-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding more base methods to TokenHandler #1259
Comments
@PinpointTownes we agree and want to do this work in our 6.x so we can easily have asp.net 3.x take a dependency. |
@kevinchalet CreateToken(SecurityTokenDescriptor ...) is defined to return by SecurityTokenHandler to return SecurityToken. I agree this method would be helpful to return a string. |
@kevinchalet sorry we missed this one for Wilson7. Will keep it on the radar for Wilson8 (no ETA) |
Type TokenType { get; } - Should this be on JsonWebToken? bool CanReadToken(string token) - OK TokenValidationResult ValidateToken(string token, TokenValidationParameters validationParameters) - we already have ValidateTokenAsync, so I don't think we need this. |
The most logical approach is to have a
Since there are now async overloads for the validation part, should these new methods be async/return |
TokenHandler
seems pretty useless as a base class, as it doesn't expose any useful method for token generation or validation.Please consider adding abstract or virtual properties/methods for at least the following APIs:
Type TokenType { get; }
bool CanReadToken(string token)
string CreateToken(SecurityTokenDescriptor tokenDescriptor)
TokenValidationResult ValidateToken(string token, TokenValidationParameters validationParameters)
The text was updated successfully, but these errors were encountered: