Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end to end integration testing for hot reload of data source in config #1866

Open
aaronburtle opened this issue Nov 7, 2023 · 1 comment · May be fixed by #2453
Open

Add end to end integration testing for hot reload of data source in config #1866

aaronburtle opened this issue Nov 7, 2023 · 1 comment · May be fixed by #2453
Assignees
@RubenCerna2079
Labels
🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal testing Test related issue.
Milestone
1.3

Comments

@aaronburtle
Copy link
Contributor

aaronburtle commented Nov 7, 2023 •
edited
Loading

We have unit tests that cover the ConfigFileWatcher, and End to End tests that cover the Runtime and Entities sections of the config being hot-reloaded, but lack coverage for the data source section.

To provide sufficient coverage, a test should be added to the hot-reload end to end tests that can start the test server with a data source of one DB type and then hot-reload to another DB type with a new connection string.
@aaronburtle aaronburtle added the testing Test related issue. label Nov 7, 2023
@aaronburtle aaronburtle self-assigned this Nov 7, 2023
@aaronburtle aaronburtle mentioned this issue Nov 7, 2023
Merged
@aaronburtle aaronburtle added this to the 0.12rc milestone Feb 7, 2024
@seantleonard seantleonard modified the milestones: 0.12rc, 1.2rc Mar 7, 2024
@seantleonard
Copy link
Contributor

Moving this + hot reload related tasks to post GA -> tracking via 1.2rc milestone.

@seantleonard seantleonard added the 🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal label May 14, 2024
@seantleonard seantleonard modified the milestones: 1.2rc, Feature Backlog May 17, 2024
@aaronburtle aaronburtle modified the milestones: Backlog, 1.3 Sep 4, 2024
@aaronburtle aaronburtle changed the title Add integration and end to end testing for hot reload of config Add end to end integration testing for hot reload of data source in config Oct 31, 2024
@RubenCerna2079 RubenCerna2079 self-assigned this Nov 5, 2024
@RubenCerna2079 RubenCerna2079 linked a pull request Nov 7, 2024 that will close this issue
Open
2 tasks
@RubenCerna2079 RubenCerna2079 linked a pull request Nov 7, 2024 that will close this issue
Added End-To-End Test for Datasource Hot-Reload #2453
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RubenCerna2079 RubenCerna2079

Labels
🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal testing Test related issue.
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Added End-To-End Test for Datasource Hot-Reload Azure/data-api-builder
3 participants
@seantleonard @RubenCerna2079 @aaronburtle