Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non integer blockSize causing byte(s) to be omitted from uploaded blobs. #31763

Open
2 of 6 tasks
willavos opened this issue Nov 14, 2024 · 1 comment
Open
2 of 6 tasks

Non integer blockSize causing byte(s) to be omitted from uploaded blobs. #31763

willavos opened this issue Nov 14, 2024 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@willavos
Copy link

willavos commented Nov 14, 2024 •
edited
Loading

  • Package Name: storage-blob
  • Package Version: 12.25.0
  • Operating system: any
  • nodejs
    • version: ? unknown
  • browser
    • name/version: chrome
  • typescript
    • version: 5.5.3
  • Is the bug related to documentation in

Describe the bug
A non-integer blockSize in BlockBlobClient.uploadData causes bytes to be omitted (on chunk boundaries?) in the uploaded file. I suspect this is a rounding error!

To Reproduce
Steps to reproduce the behavior:

  1. Create a file with 1637734 bytes long:
    • cat /dev/random | head -c 1637734 > test-file
  2. Try and upload 20 chunks, (blockSize = file size / 20 which is 81886.7)
  3. Observe a missing byte halfway through.

Expected behavior
To not omit the byte.

Screenshots
N/A

Additional context
I appreciate that this is a case of GIGO - but believe there should be a warming (at least) for poorly-conditioned blob block size / this should not result in missing byte.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) labels Nov 14, 2024
@github-actions GitHub Actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willavos