Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered key-value will not be included in the configuration #93

Open
zhiyuanliang-ms opened this issue Sep 4, 2024 · 2 comments
Open
Assignees

Comments

@zhiyuanliang-ms
Copy link
Contributor

For dynamic refresh, user can register some keyvalues as watchedSettings. The provider will monitor whether the watchedSettings are changed, if so, the provider will refresh all keyvalue it loaded. But the JS provider will only include keyvalues which selected by selector. The watchedSettings will not be included in the configuration provided by the provider.

This behavior is inconsistent with .NET provider. The screenshot below shows the .NET provider's behavior.

image

@zhiyuanliang-ms zhiyuanliang-ms self-assigned this Sep 4, 2024
@Eskibear
Copy link
Member

Eskibear commented Sep 4, 2024

It's by design. IMO the sentinel should not be included into configuration if it's not covered by any selector. I remember it has been discussed in the design review.
/cc @zhenlan to confirm that.

@zhenlan
Copy link

zhenlan commented Sep 4, 2024

I understand this behavior is different from .NET, but I also remember this has been discussed in a design review. I don't remember the exact reason. Is it consistent with our providers for python and k8s?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants