Why are my buttons not disabled or rendered like that if command cant be executed

[trashhacker]

Buttons have the same apperence even if the command cant be executed (Dark Mode)

[maxkatz6]

Button is disabling itself, when Command either is null (can't be reached) or when Command.CanExecute(param) is false.

[trashhacker]

yea ok, but its not the case for my buttons ? (:
they are disabled... but not rendered like that

[timunie]

Command binding is suspicious to me. Are you sure it points to a valid ICommand?

Edit: just saw CanExecute was called so should be correct. However as this is the root element bound to the UI might not recognize the event. Still worth to set the ICommand as a property and bind to that property.

[trashhacker]

tried your approach implemeted a porperty for the Command... now all menuitems disabled
check if the CanExecuteChanged Event is fired and result of CanExecute -> working as aspected...
but still disabled

[timunie]

Ahh and you add the MenuItem as DataTemplate. Thats not correct approch here. Instead you need to use a Style or ControlTheme.

[trashhacker]

so the hirarchical tree look like it should?
why is the dropdown empty ?

using this now

<ControlTheme x:Key="menuitemcommandtheme" TargetType="MenuItem">
     <Setter Property="Header" Value="{Binding Name}"/>
     <Setter Property="Command" Value="{Binding}"/>
     <Setter Property="Icon">
          <Setter.Value>
              <DataTemplate>
                  <Image Source="{Binding Icon, Converter={StaticResource resourceconverter}}" Width="16" Height="16" VerticalAlignment="Center"/>
                </DataTemplate>
            </Setter.Value>
        </Setter>
</ControlTheme>

[trashhacker]

well when i set the ItemContainerTheme its not showing the subitems... even if they exist

[timunie]

@trashhacker please provide a very minimal sample. Need to see code to help further

[trashhacker]

https://github.com/trashhacker/Avalonia.Repro.Menu

[trashhacker]

hmm maybe the problem is general couse i have the same problem in a treeview
when i set the ItemContainerTheme my treeview is empty :/

[timunie]

You're missing BasedOn in the ControlTheme

BasedOn="{StaticResource {x:Type MenuItem}}"

[trashhacker]

oh wow, ty a lot