Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES Modules #250

Open
mjeanroy opened this issue Dec 22, 2019 · 4 comments
Open

Support ES Modules #250

mjeanroy opened this issue Dec 22, 2019 · 4 comments

Comments

@mjeanroy
Copy link

Hi @jfarcand,

Currently, the codebase supports AMD, commonjs and global (the UMD pattern).
But, there is not support for ES Modules, so my question is: is there a plan to support it?

There are a lot of benefits by using ES Modules, such as tree shaking for example.
I think that adding support for ES Modules need some changes, at least:

  • Do not rely on java yui compressor, since it does not support ES Modules.
  • Distribute both UMD package and ES packages.

If that is something that can interest you, I think I can start working on it.
What do you think?

@Artur-
Copy link
Contributor

Artur- commented Oct 13, 2022

What do you think about this @jfarcand? Everything is starting to be esm these days and some tooling even requires esm. We currently have a problem with using Atmosphere because of a @web/dev-server issue

In the world I am living in, no other distribution than ESM is needed at all but others might have different needs.

Artur- added a commit to Artur-/atmosphere-javascript that referenced this issue Oct 13, 2022
@Artur-
Copy link
Contributor

Artur- commented Oct 13, 2022

I published an esm version as https://www.npmjs.com/package/a-atmosphere-javascript to get around this

@jfarcand
Copy link
Member

@Artur- Sound like I've completely missing the message from @mjeanroy. I would have say GO let's do it.

@jfarcand
Copy link
Member

@Artur- Just do a pull request and I will release it under 4.0.0, and maintain 3.1.x amd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants