Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP#31 Event::UpdateTargeting (UPDATE_TARGETING) #335

Closed
4 of 5 tasks
elpiel opened this issue Sep 17, 2020 · 0 comments · Fixed by #352
Closed
4 of 5 tasks

AIP#31 Event::UpdateTargeting (UPDATE_TARGETING) #335

elpiel opened this issue Sep 17, 2020 · 0 comments · Fixed by #352
Assignees
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Sep 17, 2020

Sentry is still missing some impl details that were already made in the JS Sentry.

Since the introduction of https://github.com/AdExNetwork/aips/issues/31 there is a new Event type that was added called UPDATE_TARGETING.

TODO:

  • Add the new Event type
  • Update the channel
  • Apply the correct access restrictions in sentry/src/access.rs
  • Test additions in access.rs
  • impl tests for the route
    Note: This is related to EventAggregator changes #319 since it's calling the EventAggregator
@elpiel elpiel changed the title Event::UpdateTargeting (UPDATE_TARGETING) AIP#31 Event::UpdateTargeting (UPDATE_TARGETING) Sep 17, 2020
@elpiel elpiel mentioned this issue Oct 26, 2020
9 tasks
@elpiel elpiel added this to the sentry-v0.2.0 milestone Jan 5, 2021
@simzzz simzzz closed this as completed Jan 7, 2021
@elpiel elpiel linked a pull request Jan 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants