Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl AIP#31 changes to Payout #323

Closed
2 tasks done
elpiel opened this issue Jul 16, 2020 · 2 comments
Closed
2 tasks done

impl AIP#31 changes to Payout #323

elpiel opened this issue Jul 16, 2020 · 2 comments
Assignees
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Jul 16, 2020

Changes

get_payout() - Progress has been made in #313 however there are still work to be done to ensure it's aligned with JS

TODOs:

  • Double check input for targeting rules:

https://github.com/AdExNetwork/adex-validator-stack-rust/blob/73683e8f38f12e497e8f8a38632378767f4dfdf9/sentry/src/payout.rs#L52-L76

  • Tests with targeting_rules set on Channel::targeting_rules or ChannelSpec::targeting_rules
elpiel added a commit that referenced this issue Aug 21, 2020
@elpiel elpiel mentioned this issue Oct 26, 2020
9 tasks
@elpiel elpiel added this to the sentry-v0.2.0 milestone Jan 5, 2021
@elpiel
Copy link
Member Author

elpiel commented Mar 19, 2021

@simzzz did you check out all the TODOs for the targeting input? Meaning: To check if all of them should be set or not when the payout needs to calculate the targeting input.

PS: I see that the todos haven't been removed.

@elpiel
Copy link
Member Author

elpiel commented Mar 25, 2021

All todos have been checked accordingly to @simzzz , closing this issue.
Todo comments will be removed with AIP#61 #377

@elpiel elpiel closed this as completed Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants