sbsa-acs should show a failure rather than skipping test for No SMMU case

[sunnywang-arm]

Now if the system doesn't have SMMU, sbsa-acs is showing "No SMMU Controller Found, Skipping SMMU tests..." rather than a failure. Per Table 2: SBSA level mapping summary in SBSA specification, it looks like a SMMU is required in SBSA level 3. I'm not sure if we have a level 3 test to check the configurations mentioned in Table 2. If not, we will need to add a test for it.

It looks like we should remove the code block below in val\sbsa\src\sbsa_execute_test.c.

  num_smmu = val_iovirt_get_smmu_info(SMMU_NUM_CTRL, 0);
  if (num_smmu == 0) {
    val_print(ACS_PRINT_WARN, "\n     No SMMU Controller Found, Skipping SMMU tests...\n", 0);
    return ACS_STATUS_SKIP;
  }

[chetan-rathore]

Hi @sunnywang-arm,

Agree, that the check is not required for SBSA and only needed in BSA.

On the SBSA L3 no smmu failure, currently as per SBSA L3 checklist required BSA SMMU rules are run.
Since, BSA doesn't mandates systems to have SMMU, smmu tests are skip if no SMMU.
We might need to add condition to the tests to fail, if run as part of SBSA L3.

Please share your thoughts.

Thanks,
Chetan

[sunnywang-arm]

Thanks for the prompt follow-up, @chetan-rathore.
As we discussed offline, Table 2 is indicative and not normative, which means SMMU is required in SBSA L4 rather than L3. Therefore, we can probably keep the code block for only L3.

[chetan-rathore]

Hi @sunnywang-arm,

Currently there are no sbsa direct test at L3, and the code block was incorrectly skipping the SMMU L4+ tests if no smmu.
In future, when SBSA l3 test are added, we will make necessary changes to skip L3 test if no SMMU.

[sunnywang-arm]

Oh, I got it. I thought the fix was #514 (the one linked to this issue) but it turned out ARM-software/bsa-acs#391 is the fix. I checked the wrong pull request. Yeah, the fix looks good to me. Thanks, @chetan-rathore and @ajayswar-s

ARM-software/bsa-acs@20afb64