Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong message clicking on craftSign on craft piloted by different player #587

Open
goodroach opened this issue May 23, 2023 · 1 comment
Labels
bug Issues causing negative effects for end users

Comments

@goodroach
Copy link
Contributor

Describe the bug
The title says it all, think there is a bug with the logic because I remembered there being a specific message for that.

To Reproduce
Steps to reproduce the behavior:

  1. Have someone else pilot a craft for you
  2. Try to click on their craft sign
  3. "You are already commanding a craft!"

Expected behavior
The message should say something else, maybe something like a generic "Craft is already commanded!" or a more specific "Someone else is commanding this craft!"

Versions (please complete the following information):

  • Movecraft: [8.0.0 Beta 1]
  • Addons: [Not sure if this matters]
  • Java [JDK 16]
  • Minecraft 1.16.5

Additional context
This should probably be on the backburner but I'm writing this down so we are aware of this issue.

@goodroach goodroach added the bug Issues causing negative effects for end users label May 23, 2023
@TylerS1066
Copy link
Contributor

Good idea, it should probably be a simple fix to CraftSign.java, the issue is that we always return that response regardless of who is the pilot around line 106.

@TylerS1066 TylerS1066 moved this from New to Ready for Work in Issue Triage May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues causing negative effects for end users
Projects
Status: Ready for Work
Development

No branches or pull requests

2 participants