Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolution of g-modes #27

Open
higl opened this issue Nov 27, 2018 · 1 comment
Open

resolution of g-modes #27

higl opened this issue Nov 27, 2018 · 1 comment

Comments

@higl
Copy link
Contributor

higl commented Nov 27, 2018

With the test_stability problem we found out, that maestro is not doing very well around peaks in the brunt-vaisala frequency (N). We attributed this to unresolved (reflected, interacting ....) g-modes in these areas.

Fabian Miczek proposed a much simpler test setup in his PhD thesis where one follows a single g-mode in a stably stratified ideal gas with constant N. Such a wave should move at a constant amplitude with constant speed, which gives us the chance to compare the code to this analytic solution.

I set up this problem (g_wave_package) in my fork in the commit 9ee6406 . (including a notebook for a quick first analysis)
g-mode_resolved_maestro

An amplitude decrease is somewhat expected due to numerical dissipation, but the one found here seems a bit large. On the other hand, it looks like we can resolve the speed rather well (at least for small dt), but for some reason the wave splits and moves in both directions (which might explain the amplitude decrease).

@zingale
Copy link
Member

zingale commented Nov 28, 2018

can you do a PR with this problem and the script to produce the plot comparing to analytic?

@higl higl mentioned this issue Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants