Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module LiverSegments - designed as both Scriptable&Loadable module - needs refactoring #201

Open
gatangen opened this issue Feb 8, 2023 · 2 comments
Assignees
Labels
design Design considerations enhancement New feature or request
Milestone

Comments

@gatangen
Copy link
Contributor

gatangen commented Feb 8, 2023

Describe the bug
The design of module LiverSegments has both Python and C++ code and is initialised as a Scriptable module. It has logic code both in python and C++ which is confusion when using the module and when unit testing.

To Reproduce
Only relevant to code design.

Expected behavior
The module should be refactored to have a clear logic API in C++ and be initialised as a Loadable module.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macOS
  • Version 12.6.3

Additional context
Add any other context about the problem here.

@gatangen gatangen added the bug Something isn't working label Feb 8, 2023
@gatangen gatangen added this to the Slicer-Liver v1.0 milestone Feb 8, 2023
@gatangen gatangen self-assigned this Feb 8, 2023
@RafaelPalomar
Copy link
Collaborator

The more we can translate to C++ the better (in general terms, this is what I think). We should discuss about the possibility to have Liver as a metamodule and an arena to introduce experimental changes and port these changes to C++ loadable modules.

@RafaelPalomar RafaelPalomar added enhancement New feature or request design Design considerations and removed bug Something isn't working labels Mar 1, 2023
@RafaelPalomar
Copy link
Collaborator

Decided on 20/03/2023 that the liver segments module should go on C++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design considerations enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants