Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resectogram grid visualization issues with thickness #190

Open
RafaelPalomar opened this issue Jan 19, 2023 · 3 comments
Open

Resectogram grid visualization issues with thickness #190

RafaelPalomar opened this issue Jan 19, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on
Milestone

Comments

@RafaelPalomar
Copy link
Collaborator

When the thickness value of the grid for the resectogram is low, some of the grid lines are not drawn. Maybe setting a minimum value for the grid thickness would solve the problems.

@RafaelPalomar RafaelPalomar added the enhancement New feature or request label Jan 19, 2023
@RafaelPalomar RafaelPalomar added this to the Slicer-Liver v1.0 milestone Jan 19, 2023
@RuoyanMeng
Copy link
Collaborator

RuoyanMeng commented Jan 19, 2023

I tested this, it seems different grid divisions need different thickness values to work perfectly when rendering. So we need an equation calculating the corresponding thickness every time grid divisions change.
For example:
grid divisions = 20, thickness=3.2, missing lines
Screenshot from 2023-01-19 13-13-07

grid divisions = 20, thickness=4.5, work perfectly
Screenshot from 2023-01-19 13-12-59

grid divisions = 20, thickness=6.1, some lines are bold
Screenshot from 2023-01-19 13-13-16

@RafaelPalomar
Copy link
Collaborator Author

RafaelPalomar commented Jan 23, 2023

I suspect applying anti-aliasing will help on this.

Anti-aliasing is in 3D Slicer settings, but in practice I think it is not applied; it is possible to enable that by code though, but it may have side effects: https://discourse.slicer.org/t/antialiasing-in-in-slice-mpr-views/21140

@RuoyanMeng
Copy link
Collaborator

I suspect applying anti-aliasing will help on this.

Anti-aliasing is in 3D Slicer settings, but in practice I think it is not applied; it is possible to enable that by code though, but it may have side effects: https://discourse.slicer.org/t/antialiasing-in-in-slice-mpr-views/21140

I tried this, before and after FXAA was enabled, and there is no obvious improvement. For now, I would suggest we limit the grid division value to 0 - 30, and set a minimum thickness value of 4.6, to make sure when the grid division value is between 0 - 30 everything works as expected.

RuoyanMeng added a commit to RuoyanMeng/Slicer-Liver that referenced this issue Mar 6, 2023
@RafaelPalomar RafaelPalomar added the wontfix This will not be worked on label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants