New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks are missing #11

Open

max0x7ba opened this issue Mar 26, 2021 · 0 comments

max0x7ba commented Mar 26, 2021 •

edited

Loading

python-cjson states:

The module is written in C and it is up to 250 times faster when compared to the other python JSON implementations which are written directly in python. This speed gain varies with the complexity of the data and the operation and is the the range of 10-200 times for encoding operations and in the range of 100-250 times for decoding operations.

Impressive claims.

A couple of questions from a critical thinker:

Where do I find the benchmarks the claims are based upon, please?
Since the main selling point of the project is speed, where is that unit test that verifies that the speed advantage is within an expected range, please? If that test isn't in CI, a commit could destroy the speed advantage without notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment