Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User-Dispatchable Config Testing Workflow #119

Closed
CodeGat opened this issue Sep 5, 2024 · 3 comments
Closed

Add User-Dispatchable Config Testing Workflow #119

CodeGat opened this issue Sep 5, 2024 · 3 comments
Assignees
Labels
CI Continuous integration infrastructure

Comments

@CodeGat
Copy link
Contributor

CodeGat commented Sep 5, 2024

In a similar vein to https://github.com/ACCESS-NRI/access-om2-configs/blob/main/.github/workflows/generate-initial-checksums.yml, collaborate with @anton-seaice to create a similar user-dispatchable workflow for checksum creation.

Some initial questions (which may require a slight reworking of ACCESS-NRI/model-config-tests CI):

  • Tagging of checksums isn't required, so if we don't use tags, what do we compare checksums against?
@CodeGat CodeGat self-assigned this Sep 5, 2024
@CodeGat CodeGat added the CI Continuous integration infrastructure label Sep 5, 2024
@anton-seaice
Copy link
Contributor

I think in a PR, compare against the checksum in the branch being merged into.

For a user-triggered workflow, maybe the user has to specify the branch with the checksum to compare to?

Although, typically, a branch named

feat-025_jra55do_ryf-iss191 could be compared to dev-025_jra55do_ryf

Anyway - I think I don't understand the question ... in generating initial checksums there is nothing to compare against ... ?

@CodeGat
Copy link
Contributor Author

CodeGat commented Sep 10, 2024

Ah correct, initial checksums wouldn't have to compare to anything :D I was thinking about the future case for PRs

@CodeGat
Copy link
Contributor Author

CodeGat commented Sep 10, 2024

Closed via #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration infrastructure
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants