Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading yarn editor to the newest version #6460

Open
blurymind opened this issue Mar 15, 2024 · 3 comments
Open

Upgrading yarn editor to the newest version #6460

blurymind opened this issue Mar 15, 2024 · 3 comments

Comments

@blurymind
Copy link
Contributor

blurymind commented Mar 15, 2024

Description

I am wondering if its worth making a pr to upgrade yarn editor to a newer version.
There are some missing bits and fixed bugs/ improvement of life features in the newest version. Is this something that would be welcome as a Pr?

Improvements over the old one:

  • much better performance with big big files
  • support for ink story file format import and export + syntax (possibly useful for the future)
  • better handling of touch input and small size screens (smartphones/tablets)
  • bug fixes

Solution suggested

Before doing a PR I think I will do some work on yarn editor to trim it down - to reduce its size. It has grown in size due to bundling of an inkjs compiler and some word library files - to enable previewing ink stories directly inside yarn + suggestion of related words to selected word.

I am planning to trim it down and speed up its start time, so the ink playtesting feature might be reworked or removed, but the optional ink import/export/syntax support will stay

Alternatives considered

I really want gdevelop's web version to be able to open yarn editor the way it can now do piskel. Can anyone point me to any tips as to what needs doing to enable this for yarn editor?

@blurymind
Copy link
Contributor Author

blurymind commented Mar 25, 2024

Might give this one higher priority than upgrading bondagejs, seeing as to how its getting more hearts.

I did some work on yarn editor to trim down its bundle size while keeping as many of the new features as possible over the weekend.
I can also say that it handles giant files (over 500+ nodes with lots of text) much much more efficiently than what is currently used in Gdevelop.

There was some badly optimised stuff. Like typing to search for a node was very slow, panning was slow, loading the file was slow. There is always room to improve it still. It should be able to scale to bigger documents

I still want to try tackling this one first
blurymind/YarnClassic#322

@MTSyntho
Copy link
Contributor

I think the implementation of the new yarn editor + being able to handle tons of nodes will be incredibly useful for my upcoming via move, would contribute if i really understood js, ts & such much more but sadly can't, still tho keep up the great work 🗣️📢🔥

@blurymind
Copy link
Contributor Author

blurymind commented May 27, 2024

yup I understand the demand. The good news is that I managed to trim down the newest version of yarn to almost the same size as it is now in gdevelop's old version, while retaining all the new the features.

I remember when I initially did the bundle pr - the deploy size being small was a very important point.
There are some api changes that came with turning it into a pwa, which may need proper re-testing in its wrapper in gdevelop

I want to sort out my vn actor pr before doing the yarn editor upgrade though
#6469

so in the mean time I am just working on yarn itself.
You can try out the newest version as a pwa here:
https://blurymind.github.io/YarnClassic/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants