Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment for DynamicMethodBodyReaderOptions #554

Closed
wants to merge 2 commits into from
Closed

Update comment for DynamicMethodBodyReaderOptions #554

wants to merge 2 commits into from

Conversation

CreateAndInject
Copy link
Contributor

Close #552

@wtfsck
Copy link
Contributor

wtfsck commented Apr 28, 2024

This PR does more than the PR title says. Why did you add new code?

@wtfsck
Copy link
Contributor

wtfsck commented Apr 28, 2024

I see, seems like it's based on your other PR #553 .

You should create a new branch with just the comment fix and force push.

@CreateAndInject
Copy link
Contributor Author

I see, seems like it's based on your other PR #553 .

You should create a new branch with just the comment fix and force push.

Maybe because I modify the same line? Maybe File changed will show this commit change only when that PR merged. Let's see how it shows when that PR merged to decide if it need be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I already know how UnknownDeclaringType happen
2 participants
@CreateAndInject @wtfsck